Skip to content

Adding dynamodb support to get_resources in resourcegroupstagging api#7471

Merged
bblommers merged 1 commit intogetmoto:masterfrom
ppapishe:add_ddb_supp
Mar 17, 2024
Merged

Adding dynamodb support to get_resources in resourcegroupstagging api#7471
bblommers merged 1 commit intogetmoto:masterfrom
ppapishe:add_ddb_supp

Conversation

@ppapishe
Copy link
Copy Markdown
Contributor

Currently, mock_resourcegroupstagging is not able to get the dynamodb tables created using mock_dynamodb. This PR is to add that support.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (9aef694) to head (d4cef81).
Report is 107 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7471      +/-   ##
==========================================
- Coverage   95.88%   95.81%   -0.08%     
==========================================
  Files         843      854      +11     
  Lines       82578    84012    +1434     
==========================================
+ Hits        79178    80492    +1314     
- Misses       3400     3520     +120     
Flag Coverage Δ
servertests 32.22% <50.00%> (-0.30%) ⬇️
unittests 95.77% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @ppapishe!

@bblommers bblommers added this to the 5.0.4 milestone Mar 17, 2024
@bblommers bblommers merged commit 5a0bc0d into getmoto:master Mar 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This is now part of moto >= 5.0.4.dev24

@ppapishe ppapishe deleted the add_ddb_supp branch April 12, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants