Added support for UnicodeCombiningMark, fixes #3639.#3645
Added support for UnicodeCombiningMark, fixes #3639.#3645ctjlewis wants to merge 0 commit intogoogle:masterfrom
Conversation
|
Build tests are failing because: Anybody have recommendations? Not sure why I noticed the rest of the character checks did not use builtins like Edit: Is this breaking because it's being fed into J2CL, which can't compile |
|
Opened an issue at google/j2cl#103 regarding future-proofed Unicode category checks, just need J2CL to support |
.gitignore
Outdated
| /bazel-bin | ||
| /bazel-closure-compiler | ||
| /bazel-out | ||
| /bazel-testlogs No newline at end of file |
There was a problem hiding this comment.
Running ./build_test.sh created bazel output directories that were added to the git tree by default. These lines prevent that.
| | (ch >= 0x03B1 & ch <= 0x03C9); // Greek lowercase letters | ||
| } | ||
|
|
||
| // Check if char is Unicode Category "Combining spacing mark (Mc)" |
utils/run.sh
Outdated
| #!/bin/bash | ||
| # Run the local build of CC in target/. Make sure to run build.sh before running | ||
| # this script. | ||
| java -jar target/closure-compiler-1.0-SNAPSHOT.jar $@ |
There was a problem hiding this comment.
Handy for debugging local build.
Some notes:
utils/directory was added, which contains a script for building the source (without GWT) and a script for calling that built version with the given args. This directory will be a good place to put bash scripts in the future, includingruntime_tests.shto execute the jsComp runtime tests (a separate issue I'm working on).isConnectorPunctuation,isZeroWidthJoiner, etc.), which will prevent issues like this in the future. I intend to do this over the coming days, I just wanted to get this PR in first.This PR fixes #3639, and you can see that the source:
now compiles as expected to: