Skip to content

Improve unicode escape in regex#3656

Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom
HenryRLee:regexUnicode
Aug 11, 2020
Merged

Improve unicode escape in regex#3656
copybara-service[bot] merged 1 commit intogoogle:masterfrom
HenryRLee:regexUnicode

Conversation

@HenryRLee
Copy link
Copy Markdown
Contributor

This PR supports regex Unicode escape in curly brackets format, provided that the 'u' flag presents.

For example:

let x = /\u{01ac}/u;

Also, it extends Unicode up to 0x10FFFF. For example:

let x = /\u{10FFFF}/u;

I believe this PR also fixes issue #3563.

@google-cla google-cla bot added the cla: yes label Aug 8, 2020
@ctjlewis
Copy link
Copy Markdown
Contributor

ctjlewis commented Aug 9, 2020

Nice work, Henry! Code LGTM.

I actually submitted a couple of Unicode logic PRs myself to try to learn more about the standard - I'd love if you could review one of them for me. See #3645, #3647.

@HenryRLee
Copy link
Copy Markdown
Contributor Author

Thanks @christiantjl.

I saw your PRs. #3645 looks good to me. When I have time, I will verify the correctness of the Unicode categories in #3647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants