containeranalysis: connection is not shared

[thepwagner]

Client

Grafeas

Go Environment

go version go1.17.5 darwin/arm64

Expected behavior

Documentation on containeranalysis.Client.GetGrafeasClient() states "Calling Close on either the grafeas or containeranalysis client will close the shared connection in both." source.

I expect calling close on either client to close the shared connection in both.

Actual behavior

containeranalysis.NewClient() initializes a connection pool, but it is not shared with grafeasclient source.
grafeas.NewClient() initializes an independent connection pool source.

Additional context

I think the comment should be removed, or the connection pool between these clients should be shared.

[codyoss]

@thepwagner Thanks for pointing this out. As far as I can see this has never been a true statement I will update code/docs accordingly.