fix(containeranalysis): fix docs and closing of client.#5220
Merged
codyoss merged 3 commits intogoogleapis:mainfrom Jan 10, 2022
Merged
fix(containeranalysis): fix docs and closing of client.#5220codyoss merged 3 commits intogoogleapis:mainfrom
codyoss merged 3 commits intogoogleapis:mainfrom
Conversation
It was documented that the embeded grafeas client shared a connection with the main client, but it does not and never has from looking at history. Updated the comment but also explicitly called close on the grafeas client when the containeranalysis client is closed. Fixes: googleapis#5217
product-auto-label
Bot
added
the
api: containeranalysis
noahdietz
approved these changes
Dec 16, 2021
This was referenced Feb 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was documented that the embeded grafeas client shared a connection
with the main client, but it does not and never has from looking at history.
Updated the comment but also explicitly called close on the grafeas client
when the containeranalysis client is closed.
Fixes: #5217