Skip to content

chore: add a config check#14327

Merged
JoeWang1127 merged 14 commits intogoogleapis:mainfrom
JoeWang1127:chore/add-librarian-check
Apr 1, 2026
Merged

chore: add a config check#14327
JoeWang1127 merged 14 commits intogoogleapis:mainfrom
JoeWang1127:chore/add-librarian-check

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Apr 1, 2026

Add a presubmit check to verify library name and version are consistent among state.yaml and librarian.yaml.

Update the version of pubsub and pubsub/v2 since these two libraries are released with an old version of legacylibrarian. Using legacylibrarian v0.9.1 and above will update version in librarian.yaml automatically.

For googleapis/librarian#4422
Fixes googleapis/librarian#4943

@JoeWang1127 JoeWang1127 requested review from a team as code owners April 1, 2026 20:44
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@JoeWang1127 JoeWang1127 requested a review from a team as a code owner April 1, 2026 20:54
Comment thread .github/workflows/config_check.yml
"language": "GO",
"name": "cloud.google.com/go/pubsub/v2/apiv1",
"version": "2.5.0"
"version": "2.5.1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, or you were trying to induce a difference for testing?

Copy link
Copy Markdown
Contributor Author

@JoeWang1127 JoeWang1127 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates is caused by #14312

The release was done via an old version of legacylibrarian (v0.8.3) so the version in librarian.yaml is not updated. The latest version of legacylibrarian (v0.9.1 and above) will update version in librarian.yaml as well.

The check detected the version discrepancy and I updated it to be same in state.yaml.

@JoeWang1127 JoeWang1127 requested a review from shollyman April 1, 2026 22:51
@JoeWang1127 JoeWang1127 merged commit a70f04f into googleapis:main Apr 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

golang: create a check to verify library configs in librarian.yaml and state.yaml are in sync

2 participants