-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: add a config check #14327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a config check #14327
Changes from 12 commits
f46fdef
6963015
4381727
048c8ed
a128c5f
e751399
a551517
bb082c7
8a61074
1bb981d
2dbb2f7
2e7d5f5
e8ddd98
434558b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| name: config check | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
| permissions: | ||
| contents: read | ||
| jobs: | ||
| config-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Config check | ||
| run: | | ||
| V="$(sed -n 's/^version: *//p' librarian.yaml)" | ||
| go run "github.com/googleapis/librarian/tool/cmd/configcheck@${V}" . | ||
| - name: Update library versions and regenerate | ||
| if: failure() | ||
| run: | | ||
| echo "Library version is different between state.yaml and librarian.yaml. | ||
| Update versions in the configs according to the error message and | ||
| regenerate libraries using: | ||
|
|
||
| V=\$(sed -n 's/^version: *//p' librarian.yaml) | ||
| go run github.com/googleapis/librarian/cmd/librarian@\${V} generate --all | ||
| " | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| ], | ||
| "language": "GO", | ||
| "name": "cloud.google.com/go/pubsub/v2/apiv1", | ||
| "version": "2.5.0" | ||
| "version": "2.5.1" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated, or you were trying to induce a difference for testing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This updates is caused by #14312 The release was done via an old version of legacylibrarian (v0.8.3) so the version in librarian.yaml is not updated. The latest version of legacylibrarian (v0.9.1 and above) will update version in librarian.yaml as well. The check detected the version discrepancy and I updated it to be same in state.yaml. |
||
| }, | ||
| "snippets": [ | ||
| { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.