feat: enable open telemetry attrs#14426
Merged
noahdietz merged 1 commit intogoogleapis:mainfrom Apr 13, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements telemetry and metrics support across a wide range of generated clients in the accessapproval, accesscontextmanager, advisorynotifications, ai/generativelanguage, and aiplatform packages. The changes include conditional initialization of telemetry attributes and client metrics based on feature flags, as well as the injection of telemetry context (such as resource names and RPC methods) into outgoing requests. I have no feedback to provide as there are no review comments to assess.
shollyman
approved these changes
Apr 13, 2026
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
config goes in, generated code comes out
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regen from #14380