Skip to content

chore: librarian release pull request: 20260414T185624Z#14436

Closed
hongalex wants to merge 1 commit intomainfrom
librarian-20260414T185624Z
Closed

chore: librarian release pull request: 20260414T185624Z#14436
hongalex wants to merge 1 commit intomainfrom
librarian-20260414T185624Z

Conversation

@hongalex
Copy link
Copy Markdown
Member

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.

Librarian Version: v0.8.3
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a

pubsub/v2: v2.6.0

v2.6.0 (2026-04-14)

Features

Bug Fixes

Documentation

@hongalex hongalex requested review from a team as code owners April 14, 2026 18:56
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pubsub/v2 library to version 2.6.0, including updates to the changelog, internal version constants, and snippet metadata. Additionally, it modifies the .librarian/state.yaml file by removing the license header and adding a service_config field to several API entries. Feedback was provided regarding the .librarian/state.yaml file, noting that the service_config field was omitted for the pubsub/v2 entry while being added to others for consistency.

Comment thread .librarian/state.yaml
tag_format: '{id}/v{version}'
- id: pubsub/v2
version: 2.5.1
version: 2.6.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The service_config field is being added to API entries for other libraries in this PR (e.g., appoptimize at line 238, biglake at lines 451 and 453, datacatalog at line 915) to normalize the schema. However, it appears to be missing for the pubsub/v2 entry's API (google/pubsub/v1) on line 2157. For consistency and to ensure the state file adheres to the updated schema, consider adding service_config: "" to that entry as well.

@hongalex hongalex closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant