golang: daily generation check failed because version in snippet metadata is not updated by legacylibrarian release

[JoeWang1127]

We installed a daily generation check in google-cloud-go: https://github.com/googleapis/google-cloud-go/actions/workflows/generation_check.yaml

The check failed and created: googleapis/google-cloud-go#14342

The reason of the diff is because release pull request (googleapis/google-cloud-go#14330) didn't update version in snippet metadata.

[jskeet]

Drive-by comment (not really working today, honest). That's unexpected - I would have expected the snippet files to be bumped by https://github.com/googleapis/google-cloud-go/blob/main/internal/librariangen/release/release.go#L83

As an example, googleapis/google-cloud-go#14270 did bump the snippet files. Perhaps the snippet bumping code has been broken by reformatting the snippets?

[JoeWang1127]

Drive-by comment (not really working today, honest). That's unexpected - I would have expected the snippet files to be bumped by https://github.com/googleapis/google-cloud-go/blob/main/internal/librariangen/release/release.go#L83

@jskeet thanks for the information. I'll take a look.

[JoeWang1127]

The snippet version is not updated because the API has been removed for each library: https://github.com/googleapis/google-cloud-go/blob/b3409e6d7fbb5708e6be6000a1257a741c23b63b/internal/librariangen/module/module.go#L79

[JoeWang1127]

I'll bring back APIs in state.yaml so that legacylibrarian release can update snippet directory.