chore(internal/librarian): add snippet directories to legacy state#5137
Merged
JoeWang1127 merged 1 commit intomainfrom Apr 6, 2026
Merged
chore(internal/librarian): add snippet directories to legacy state#5137JoeWang1127 merged 1 commit intomainfrom
JoeWang1127 merged 1 commit intomainfrom
Conversation
JoeWang1127
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the createLegacyLibrary function to include generated snippet paths in SourceRoots and exclude them from releases via ReleaseExcludePaths. Corresponding test cases have been updated to reflect these changes. Feedback suggests defining a constant for the hardcoded snippet path prefix to improve maintainability and addressing the trailing slash inconsistency between the source root and the exclusion path.
noahdietz
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
createLegacyLibraryfunction is updated to include the generated snippets directory in both theSourceRootsandReleaseExcludePathsfields for the legacy configuration.Snippet directory needs to be present in
SourceRootsso that the updated snippet metadata can be copied from docker response to language repository.Snippet directory needs to be present in
ReleaseExcludePathsso that changes in this directory will cause a release.See go/sdk-librarian-interim-state for more details.
Fixes #5034