This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Conversation
googlebot
added
the
cla: yes
Contributor
|
Nice! The system and sample tests are currently down for this one, and we would need to get those passing first though :) |
JustinBeckwith
approved these changes
Sep 28, 2018
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Assuming all CI is passing
| @@ -94,6 +94,7 @@ | |||
| "request": "^2.88.0", | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
I was wondering how that tests ran so fast. No problem with waiting. Who is working on fixing the system tests? |
fhinkel
force-pushed
the
withTeeny
branch
2 times, most recently
from
676d053 to
46883d5
Compare
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
|
@fhinkel I think we have the tests worked out over here. Can you resolve conflicts and give this another go? Thanks! |
Contributor
Author
|
@kinwa91 Can I go ahead and merge or are we in the middle of releasing? |
fhinkel
added a commit
that referenced
this pull request
Oct 12, 2018
System-tests broke with that commit. This reverts commit c2c1382.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.