feat(ruby): add Gemfile.Lock updater#1790
Merged
chingor13 merged 1 commit intogoogleapis:mainfrom Jan 5, 2023
Merged
Conversation
Adds support for updating the ruby gem version in a committed Gemfile.lock file. This helps ensure that bundle install works correctly after a version.rb version change. There is also some additional logic introduced to simulate how ruby Gem::Version handles `-` with prerelease semvers (e.g. `1.0.0-alpha` is parsed as `1.0.0.pre.alpha). A future update could make use of the new common stringifyRubyVersion to translate the version into the more commonly used `.` prerelease seperatorwhich is treated "as is" and avoids the `.pre.` replacement of `-`.
Contributor
Author
|
@chingor13 - Question. What is the typical cadence for releases of |
|
I think this PR just broke my CI for a Rails application. It's now automatically overwriting the first listed gem's version in Example from a release-please PR request in a Rails repo: # Gemfile.lock
- actioncable (7.0.4)
+ actioncable (0.0.1)Release please config: steps:
- uses: GoogleCloudPlatform/release-please-action@v3
id: release
with:
release-type: ruby
version-file: "version.rb"
bump-minor-pre-major: true# Gemfile.lock
GEM
remote: https://rubygems.org/
specs:
actioncable (7.0.4)
actionpack (= 7.0.4)
activesupport (= 7.0.4)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
actionmailbox (7.0.4)
..... |
Contributor
Author
|
@kjellberg - Sorry to hear this. It looks like you haven't set a |
Contributor
Author
|
It looks like this is likely the problem. Putting together a PR to fix the issue. |
andrewthauer
added a commit
to andrewthauer/release-please
that referenced
this pull request
Jan 17, 2023
PR googleapis#1790 introduced support to update Gemfile.lock files. However this introduced an issue that updates random gem versions when the `package-name` (gemName) is not provided (which is optional). This fix ensures the gemName is valid before attempting to update the Gemfile.lock file.
This was referenced Jan 17, 2023
Closed
Makes sense.. thanks :) |
chingor13
pushed a commit
that referenced
this pull request
Jan 17, 2023
PR #1790 introduced support to update Gemfile.lock files. However this introduced an issue that updates random gem versions when the `package-name` (gemName) is not provided (which is optional). This fix ensures the gemName is valid before attempting to update the Gemfile.lock file.
carlosantoniodasilva
added a commit
to judoscale/judoscale-ruby
that referenced
this pull request
Apr 28, 2025
…iles This is meant to update the Gemfile.lock files to the new version that's being created, otherwise they'll become invalid when we merge the release PR, causing test failures and requiring us to manually run bundle install, as it happened with v1.11.0. This is a combination of "I hope it works", based on some searching and putting pieces together: googleapis/release-please#1768 googleapis/release-please#1790 googleapis/release-please#1621
carlosantoniodasilva
added a commit
to judoscale/judoscale-ruby
that referenced
this pull request
Apr 28, 2025
…iles This is meant to update the Gemfile.lock files to the new version that's being created, otherwise they'll become invalid when we merge the release PR, causing test failures and requiring us to manually run bundle install, as it happened with v1.11.0. This is a combination of "I hope it works", based on some searching and putting pieces together: googleapis/release-please#1768 googleapis/release-please#1790 googleapis/release-please#1621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1768 🦕
Adds support for updating the ruby gem version in a committed Gemfile.lock file. This helps ensure that bundle install works correctly after a version.rb version change. There is also some additional logic introduced to simulate how ruby Gem::Version handles
-with prerelease semvers (e.g.1.0.0-alphais parsed as `1.0.0.pre.alpha).A future update could make use of the new common stringifyRubyVersion to translate the version into the more commonly used
.prerelease seperatorwhich is treated "as is" and avoids the.pre.replacement of-.