fix(ruby): gemfile.lock should not update when gem name is empty#1805
Merged
chingor13 merged 1 commit intogoogleapis:mainfrom Jan 17, 2023
Merged
fix(ruby): gemfile.lock should not update when gem name is empty#1805chingor13 merged 1 commit intogoogleapis:mainfrom
chingor13 merged 1 commit intogoogleapis:mainfrom
Conversation
PR googleapis#1790 introduced support to update Gemfile.lock files. However this introduced an issue that updates random gem versions when the `package-name` (gemName) is not provided (which is optional). This fix ensures the gemName is valid before attempting to update the Gemfile.lock file.
chingor13
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1790 introduced support to update Gemfile.lock files. However this introduced an issue that updates random gem versions when the
package-name(gemName) is not provided (which is optional). This fix ensures the gemName is valid before attempting to update the Gemfile.lock file.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes issue introduced in PR #1790