Skip to content

Catch IndexError, KeyError in video_is_playable#2113

Merged
freddyaboulton merged 1 commit into
mainfrom
catch-index-error-in-codec-detection
Aug 29, 2022
Merged

Catch IndexError, KeyError in video_is_playable#2113
freddyaboulton merged 1 commit into
mainfrom
catch-index-error-in-codec-detection

Conversation

@freddyaboulton
Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton commented Aug 29, 2022

Description

The goal of this PR is to make the video_is_playable catch more exceptions to better account for the unpredictability of the data being returned from the inference function. Noted in this PR comment

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2113-all-demos

@freddyaboulton freddyaboulton marked this pull request as ready for review August 29, 2022 16:45
@abidlabs
Copy link
Copy Markdown
Member

LGTM @freddyaboulton nice trick to use parametrize!

@freddyaboulton freddyaboulton merged commit 85229a7 into main Aug 29, 2022
@freddyaboulton freddyaboulton deleted the catch-index-error-in-codec-detection branch August 29, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants