Skip to content

Add guide on launching background tasks from your app#2350

Merged
freddyaboulton merged 1 commit into
mainfrom
guide-background-tasks
Sep 28, 2022
Merged

Add guide on launching background tasks from your app#2350
freddyaboulton merged 1 commit into
mainfrom
guide-background-tasks

Conversation

@freddyaboulton
Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton commented Sep 27, 2022

Description

Adding a guide on how to run background tasks on a schedule from a gradio app (#2122) and how to synchronize data from gradio to the hub (#2049)

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2350-all-demos

@freddyaboulton freddyaboulton marked this pull request as ready for review September 27, 2022 20:25
@abidlabs
Copy link
Copy Markdown
Member

Traveling right now so @dawood would you be able to review this one?

But I just skimmed through the code and this is freaking awesome! Just to confirm @freddyaboulton if the Spaces machine restarts, the background scheduler would restart as well, right?

1 similar comment
@abidlabs
Copy link
Copy Markdown
Member

Traveling right now so @dawood would you be able to review this one?

But I just skimmed through the code and this is freaking awesome! Just to confirm @freddyaboulton if the Spaces machine restarts, the background scheduler would restart as well, right?

@dawoodkhan82
Copy link
Copy Markdown
Collaborator

lol sorry @dawood, @abidlabs meant me. But if you want to review as well that'd be cool.

Copy link
Copy Markdown
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, lgtm!

@freddyaboulton
Copy link
Copy Markdown
Collaborator Author

Thanks for the review @dawoodkhan82 @abidlabs ! Yep scheduler restarts when the space restarts

@freddyaboulton freddyaboulton merged commit b2275dc into main Sep 28, 2022
@freddyaboulton freddyaboulton deleted the guide-background-tasks branch September 28, 2022 15:03
@abidlabs
Copy link
Copy Markdown
Member

Whoops sorry @dawood and thank you @dawoodkhan82 and @freddyaboulton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants