Install gradio from source in UI tests#2440
Conversation
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2440-all-demos |
There was a problem hiding this comment.
Is this still necessary if we are using the updated runner (which comes with pip v22)?
There was a problem hiding this comment.
Think so otherwise you will get (no setup.py detected but found a toml instead) error
There was a problem hiding this comment.
Let me just test to see!
There was a problem hiding this comment.
💥 You were right
freddyaboulton
requested review from
abidlabs,
aliabd,
aliabid94,
dawoodkhan82 and
pngwn
There was a problem hiding this comment.
Open question but is the changelog for the repo, or just for the library?
There was a problem hiding this comment.
I interpret it as the repo. I can remove this line though since it does not impact users of the library.
There was a problem hiding this comment.
I don't mind but would be good to decide if we want it to be for the lib or for the repo. If we decide both then we should have two changelogs because the changelog is the changelog for the library first and foremost and should only include changes that impact library users.
|
Sorry i conflicted you, because i tweaked the workflow in another PR. |
freddyaboulton
force-pushed
the
install-gradio-from-source-ui-ci
branch
from
6d507fa to
255755d
Compare
|
No problem @pngwn - just rebased. Is this good to merge? |
freddyaboulton
force-pushed
the
install-gradio-from-source-ui-ci
branch
from
255755d to
b69a69d
Compare
|
yip |
2 participants
Description
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.