Skip to content

Install gradio from source in UI tests #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freddyaboulton merged 3 commits into from
Oct 12, 2022
Merged

Install gradio from source in UI tests #2440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
324c6fb
Install gradio from source
freddyaboulton Oct 12, 2022
5639fc9
CHANGELOG
freddyaboulton Oct 12, 2022
b69a69d
Do not upgrade pip
freddyaboulton Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,12 @@ jobs:
node-version: 16
cache: pnpm
cache-dependency-path: ui/pnpm-lock.yaml
- run: pip install -r ../requirements.txt
- name: Install Python
uses: actions/setup-python@v3
with:
python-version: '3.x'
- run: cd .. && bash scripts/install_gradio.sh
- run: pip install -r ../demo/outbreak_forecast/requirements.txt
- run: pip install gradio
- run: pnpm install --frozen-lockfile
- run: pnpm exec playwright install chromium
- run: pnpm test:browser:full
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ No changes to highlight.
* Decreased latency in iterative-output demos by making the iteration asynchronous [@freddyaboulton](https://github.com/freddyaboulton) in [PR 2409](https://github.com/gradio-app/gradio/pull/2409)
* Automatically restart spaces if they're down by [@aliabd](https://github.com/aliabd) in [PR 2405](https://github.com/gradio-app/gradio/pull/2405)
* Carousel component is now deprecated by [@abidlabs](https://github.com/abidlabs) in [PR 2434](https://github.com/gradio-app/gradio/pull/2434)

* Build Gradio from source in ui tests by by [@freddyaboulton](https://github.com/freddyaboulton) in [PR 2440](https://github.com/gradio-app/gradio/pull/2440)
Copy link
Copy Markdown
Member

@pngwn pngwn Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question but is the changelog for the repo, or just for the library?

Copy link
Copy Markdown
Collaborator Author

@freddyaboulton freddyaboulton Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I interpret it as the repo. I can remove this line though since it does not impact users of the library.

Copy link
Copy Markdown
Member

@pngwn pngwn Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind but would be good to decide if we want it to be for the lib or for the repo. If we decide both then we should have two changelogs because the changelog is the changelog for the library first and foremost and should only include changes that impact library users.

Copy link
Copy Markdown
Collaborator Author

@freddyaboulton freddyaboulton Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - noted in #2431


## Contributors Shoutout:
No changes to highlight.
Expand Down
⚡