Skip to content

xds: enableSpiffe also checks the new env var per gRFC-A87 #12078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejona86 merged 2 commits into from
May 19, 2025
Merged

xds: enableSpiffe also checks the new env var per gRFC-A87 #12078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
298bcbd
enableSpiffe also checks the new env var per gRFC-A87
rockspore May 19, 2025
04fe8db
add a comment
rockspore May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...va/io/grpc/xds/internal/security/certprovider/FileWatcherCertificateProviderProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@
*/
public final class FileWatcherCertificateProviderProvider implements CertificateProviderProvider {

// TODO(lwge): Remove the old env var check once it's confirmed to be unused.
@VisibleForTesting
public static boolean enableSpiffe = GrpcUtil.getFlag("GRPC_EXPERIMENTAL_SPIFFE_TRUST_BUNDLE_MAP",
false);
false) || GrpcUtil.getFlag("GRPC_EXPERIMENTAL_XDS_MTLS_SPIFFE", false);
private static final String CERT_FILE_KEY = "certificate_file";
private static final String KEY_FILE_KEY = "private_key_file";
private static final String ROOT_FILE_KEY = "ca_certificate_file";
Expand Down
⚡