Move schemamd and functionmd packages to internal#354
Merged
Conversation
bendbennett
reviewed
Apr 11, 2024
Contributor
bendbennett
left a comment
bendbennett
left a comment
There was a problem hiding this comment.
LGTM, just a question about whether this represents breaking changes and if so whether this should be reflected in the change log entries.
austinvalle
approved these changes
Apr 11, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
schemamdandfunctionmdpackages create markdown documentation from theterraform-jsonrepresentation of the provider schema and the function definition respectively for thegeneratecommand. These packages were never meant to be exposed as public packages and lack sufficient documentation as expected of such. This PR moves these packages tointernal, so that it could no longer be imported as public packages.