rd/launch_template - add partition_number attribute + validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_launch_template: add `partition_number` attribute
data_source_aws_launch_template: add `partition_number` attribute
aws_launch_template: add plan time validation to `volume_type`, `spot_instance_type`, `ipv6_addresses`, `ipv4_addresses`, `private_ip_address`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLaunchTemplate_'
--- PASS: TestAccAWSLaunchTemplate_basic (86.50s)
--- PASS: TestAccAWSLaunchTemplate_data (44.63s)
--- PASS: TestAccAWSLaunchTemplate_description (66.45s)
--- PASS: TestAccAWSLaunchTemplate_update (129.63s)
--- PASS: TestAccAWSLaunchTemplate_tags (78.96s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (71.81s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (62.00s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (112.67s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (39.65s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (40.29s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (34.92s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (105.72s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (194.07s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (102.58s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (99.01s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (316.32s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (118.82s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (117.98s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (66.85s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (155.83s)
--- PASS: TestAccAWSLaunchTemplate_disappears (27.77s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum(52.05s)



--- PASS: TestAccAWSLaunchTemplateDataSource_basic (60.08s)

...

[gdavison]

This looks great, @DrFaust92. Can you add some testing for the new fields, please?

[DrFaust92]

@gdavison , adding some tests for the partition number argument.

i'll take a look at resource groups as well, may be more tricky

[DrFaust92]

@gdavison dropped host_resource_group_arn from the PR as it requires a dedicated host

[gdavison]

LGTM 🚀

--- PASS: TestAccAWSLaunchTemplate_disappears (12.45s)
--- PASS: TestAccAWSLaunchTemplate_basic (12.88s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (14.32s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (15.21s)
--- PASS: TestAccAWSLaunchTemplate_data (16.08s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (16.76s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (17.16s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (17.28s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (17.69s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (17.73s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (18.52s)
--- PASS: TestAccAWSLaunchTemplate_tags (23.22s)
--- PASS: TestAccAWSLaunchTemplate_description (24.97s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (24.99s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (13.99s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (12.99s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (16.44s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.43s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (24.58s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (19.92s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (27.36s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (27.84s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (45.10s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (45.58s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (28.76s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (49.69s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (26.35s)
--- PASS: TestAccAWSLaunchTemplate_update (50.94s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (51.73s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (35.52s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (56.41s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (48.02s)

[ghost]

This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[Joldnine]

This change will give a default value of 0 to partition_number, causing cluster mode K8S ASG scaling up failure.

[minggaograb]

Hi this MR will break other module like terraform-aws-eks which do not explicitly handle "partition_number". The "partition_number" will become "0" and create following error.
Launching a new EC2 instance. Status Reason: Could not launch Spot Instances. InvalidParameterValue - You cannot use PartitionNumber with a Placement Group that does not exist. Specify a valid Placement Group and try again. Launching EC2 instance failed.
Can we have a default value for "partition_number" rather then 0 when other module do not explicitly handle it?

[Vlaaaaaaad]

We also make use of modules that don't handle partition_number. Since we did a couple applies today, and this broke all ASGs that used LTs.

Pinning the version for the provider fixes this:

provider "aws" {
  version = "<= 2.60.0"

  region = "us-east-1
}

[chancez]

This seems like a regression.

[BellonXiao]

I suspect this fix brought another issue:
1 error occurred:
* module.env_reg.module.envreg_cluster.aws_autoscaling_group.autoscaling_group: 1 error occurred:
* aws_autoscaling_group.autoscaling_group: Error creating AutoScaling Group: ValidationError: You must use a valid fully-formed launch template. You cannot use PartitionNumber with a Placement Group that does not exist. Specify a valid Placement Group and try again.

BTW: in our account we don't have any placement group.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!