Skip to content

r/launch_template - fix placement partition number#13239

Merged
bflad merged 2 commits into
hashicorp:masterfrom
DrFaust92:r/fix_asg_launch_template_partition
May 15, 2020
Merged

r/launch_template - fix placement partition number#13239
bflad merged 2 commits into
hashicorp:masterfrom
DrFaust92:r/fix_asg_launch_template_partition

Conversation

@DrFaust92

@DrFaust92 DrFaust92 commented May 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13236
Relates #11655

Release note for CHANGELOG:

resource_aws_launch_template: fix placement partition number to disallow zero value

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSLaunchTemplate_basic (42.44s)
--- PASS: TestAccAWSLaunchTemplate_disappears (28.76s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (89.40s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (113.19s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (149.86s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (67.50s)
--- PASS: TestAccAWSLaunchTemplate_data (41.32s)
--- PASS: TestAccAWSLaunchTemplate_description (68.95s)
--- PASS: TestAccAWSLaunchTemplate_update (121.02s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (40.91s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (51.49s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (35.05s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (45.75s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (43.08s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (45.55s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (34.94s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (85.16s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (85.63s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (183.46s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (77.26s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (41.51s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (44.00s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (124.94s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (45.93s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (41.83s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (97.52s)



--- PASS: TestAccAWSAutoScalingGroup_basic (268.04s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (84.81s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (83.41s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (151.82s)
--- PASS: TestAccAWSAutoScalingGroup_tags (278.75s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (156.81s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (397.34s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (434.09s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (184.12s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (256.30s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (309.82s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (125.89s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (85.04s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (125.63s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (284.92s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (347.68s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (243.39s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (343.04s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (87.32s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (96.53s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (91.43s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (217.60s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (102.81s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (809.89s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (88.17s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (87.23s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (150.81s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (128.11s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (101.97s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (128.51s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (151.75s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (89.97s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (127.05s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (142.73s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (177.83s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (217.61s)

@DrFaust92 DrFaust92 requested a review from a team May 9, 2020 11:01
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 9, 2020
@DrFaust92 DrFaust92 mentioned this pull request May 9, 2020
Closed
@DrFaust92 DrFaust92 changed the title [WIP]r/launch_template - fix placement partition number r/launch_template - fix placement partition number May 9, 2020
@barryib barryib mentioned this pull request May 9, 2020
Merged
2 tasks
@ewbankkit

ewbankkit commented May 9, 2020

Copy link
Copy Markdown
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_basic
=== PAUSE TestAccAWSLaunchTemplate_basic
=== RUN   TestAccAWSLaunchTemplate_disappears
=== PAUSE TestAccAWSLaunchTemplate_disappears
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_EbsOptimized
=== PAUSE TestAccAWSLaunchTemplate_EbsOptimized
=== RUN   TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== PAUSE TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== RUN   TestAccAWSLaunchTemplate_update
=== PAUSE TestAccAWSLaunchTemplate_update
=== RUN   TestAccAWSLaunchTemplate_tags
=== PAUSE TestAccAWSLaunchTemplate_tags
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_preference
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_preference
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_target
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_target
=== RUN   TestAccAWSLaunchTemplate_cpuOptions
=== PAUSE TestAccAWSLaunchTemplate_cpuOptions
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t2
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t2
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t3
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t3
=== RUN   TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== PAUSE TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== RUN   TestAccAWSLaunchTemplate_networkInterface
=== PAUSE TestAccAWSLaunchTemplate_networkInterface
=== RUN   TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== RUN   TestAccAWSLaunchTemplate_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplate_placement_partitionNum
=== PAUSE TestAccAWSLaunchTemplate_placement_partitionNum
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== RUN   TestAccAWSLaunchTemplate_instanceMarketOptions
=== PAUSE TestAccAWSLaunchTemplate_instanceMarketOptions
=== RUN   TestAccAWSLaunchTemplate_licenseSpecification
=== PAUSE TestAccAWSLaunchTemplate_licenseSpecification
=== RUN   TestAccAWSLaunchTemplate_metadataOptions
=== PAUSE TestAccAWSLaunchTemplate_metadataOptions
=== RUN   TestAccAWSLaunchTemplate_hibernation
=== PAUSE TestAccAWSLaunchTemplate_hibernation
=== CONT  TestAccAWSLaunchTemplate_basic
=== CONT  TestAccAWSLaunchTemplate_hibernation
=== CONT  TestAccAWSLaunchTemplate_metadataOptions
=== CONT  TestAccAWSLaunchTemplate_licenseSpecification
=== CONT  TestAccAWSLaunchTemplate_instanceMarketOptions
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== CONT  TestAccAWSLaunchTemplate_placement_partitionNum
=== CONT  TestAccAWSLaunchTemplate_associatePublicIPAddress
=== CONT  TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== CONT  TestAccAWSLaunchTemplate_networkInterface
=== CONT  TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t3
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t2
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== CONT  TestAccAWSLaunchTemplate_cpuOptions
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_target
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_preference
=== CONT  TestAccAWSLaunchTemplate_tags
=== CONT  TestAccAWSLaunchTemplate_update
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (25.94s)
=== CONT  TestAccAWSLaunchTemplate_description
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (27.35s)
=== CONT  TestAccAWSLaunchTemplate_data
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (29.00s)
=== CONT  TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (29.34s)
=== CONT  TestAccAWSLaunchTemplate_EbsOptimized
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (29.72s)
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (29.72s)
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
--- PASS: TestAccAWSLaunchTemplate_basic (29.95s)
=== CONT  TestAccAWSLaunchTemplate_disappears
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (30.32s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (30.38s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (30.76s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (31.60s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (35.71s)
--- PASS: TestAccAWSLaunchTemplate_tags (48.79s)
--- PASS: TestAccAWSLaunchTemplate_disappears (18.86s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (49.64s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (49.70s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (50.44s)
--- PASS: TestAccAWSLaunchTemplate_data (25.38s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (63.85s)
--- PASS: TestAccAWSLaunchTemplate_description (41.48s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (41.41s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (51.49s)
--- PASS: TestAccAWSLaunchTemplate_update (83.01s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (84.73s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (100.19s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (80.39s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (90.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	120.313s

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label May 11, 2020
@bflad bflad added this to the v2.63.0 milestone May 15, 2020
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed service/autoscaling Issues and PRs that pertain to the autoscaling service. labels May 15, 2020
@bflad bflad self-assigned this May 15, 2020
bflad
bflad approved these changes May 15, 2020
View reviewed changes

@bflad bflad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (171.95s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (285.70s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (118.21s)
--- PASS: TestAccAWSAutoScalingGroup_basic (289.54s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (126.69s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (78.93s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (236.84s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (254.46s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (39.84s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (63.24s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (196.20s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (170.82s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (693.58s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (79.29s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (49.05s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (42.20s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (106.01s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (51.32s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (170.25s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (74.39s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (49.26s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (48.53s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (68.41s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (73.56s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (142.65s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (47.08s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (76.81s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (237.62s)
--- PASS: TestAccAWSAutoScalingGroup_tags (199.87s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (341.68s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (114.77s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (78.67s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (642.03s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (320.77s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (70.40s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (166.42s)

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (26.93s)
--- PASS: TestAccAWSLaunchTemplate_basic (7.90s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (43.93s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (70.32s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (8.37s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (10.16s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (7.90s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (8.79s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (8.45s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (8.57s)
--- PASS: TestAccAWSLaunchTemplate_data (8.40s)
--- PASS: TestAccAWSLaunchTemplate_description (13.69s)
--- PASS: TestAccAWSLaunchTemplate_disappears (6.42s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (30.29s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (13.65s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (18.80s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (7.20s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (51.48s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (8.73s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (8.15s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (12.63s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (8.55s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (9.18s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (12.71s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (14.94s)
--- PASS: TestAccAWSLaunchTemplate_tags (13.82s)
--- PASS: TestAccAWSLaunchTemplate_update (47.24s)

--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (26.16s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (13.70s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (13.86s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (13.62s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (13.55s)

Comment thread aws/resource_aws_autoscaling_group_test.go Outdated
Comment thread aws/resource_aws_autoscaling_group_test.go
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSAutoScalingGroupDestroy,
DisableBinaryDriver: true,

@bflad bflad May 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This temporary flag is only necessary for acceptance testing that is checking TypeSet values at the moment.

@bflad
tests/resource/aws_autoscaling_group: Use 0 sizes for launch template…
3d96852 
… partition test


Output from acceptance testing:

```
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (46.40s)
```
@ghost ghost added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label May 15, 2020
@bflad

bflad commented May 15, 2020

Copy link
Copy Markdown
Contributor

Fun enough, it looks like the EC2 API just was updated to be able to return validation errors (thank goodness): https://github.com/terraform-providers/terraform-provider-aws/pull/13190/files#diff-6fed94e5d96961410c0aedf93f473c1fR46604 -- I will create a separate issue for that.

@bflad bflad merged commit 3b81e60 into hashicorp:master May 15, 2020
@ghost

ghost commented May 22, 2020

Copy link
Copy Markdown

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@DrFaust92 @adamdecaf
resource/aws_launch_template: Prevent downstream resource errors with…
9f2eb75 
… unconfigured partition numbers (hashicorp#13239)

Output from acceptance testing:

```
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (171.95s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (285.70s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (118.21s)
--- PASS: TestAccAWSAutoScalingGroup_basic (289.54s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (126.69s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (78.93s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (236.84s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (254.46s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (39.84s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (63.24s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (196.20s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (170.82s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (693.58s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (79.29s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (49.05s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (42.20s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (106.01s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (51.32s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (170.25s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (74.39s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (49.26s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (48.53s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (68.41s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (73.56s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (142.65s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (47.08s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (76.81s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (237.62s)
--- PASS: TestAccAWSAutoScalingGroup_tags (199.87s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (341.68s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (114.77s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (78.67s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (642.03s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (320.77s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (70.40s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (166.42s)

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (26.93s)
--- PASS: TestAccAWSLaunchTemplate_basic (7.90s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (43.93s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (70.32s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (8.37s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (10.16s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (7.90s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (8.79s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (8.45s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (8.57s)
--- PASS: TestAccAWSLaunchTemplate_data (8.40s)
--- PASS: TestAccAWSLaunchTemplate_description (13.69s)
--- PASS: TestAccAWSLaunchTemplate_disappears (6.42s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (30.29s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (13.65s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (18.80s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (7.20s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (51.48s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (8.73s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (8.15s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (12.63s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (8.55s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (9.18s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (12.71s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (14.94s)
--- PASS: TestAccAWSLaunchTemplate_tags (13.82s)
--- PASS: TestAccAWSLaunchTemplate_update (47.24s)

--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (26.16s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (13.70s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (13.86s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (13.62s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (13.55s)
```
@ghost

ghost commented Jun 14, 2020

Copy link
Copy Markdown

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2020
@DrFaust92 DrFaust92 deleted the r/fix_asg_launch_template_partition branch June 23, 2020 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bflad bflad

Labels

bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v2.63.0

Development

Successfully merging this pull request may close these issues.

Invalid aws_launch_template being created with v2.61.0

4 participants

@DrFaust92 @ewbankkit @bflad @breathingdust
⚡