Merged
Conversation
Since: - the version check was pretty broken (only matches against that exact requirements file version syntax, plus doesn't check unpinned but still outdated version etc) - it only warned for Django 1.x, when there are lots of other EOL Django versions since then - it feels inconsistent for us to warn about one framework being EOL when there are lots of other packages and frameworks out there that should also be kept up to date too -- that's best handled by services like Dependabot security alerts etc If at such time in the future our Django collectstatic feature requires a specific version of Django, any version checking/warning should occur as part of that feature. GUS-W-11593026.
edmorley
force-pushed
the
rm-django-version-warning
branch
from
9639a95 to
d87b5d7
Compare
Malax
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since:
If at such time in the future our Django collectstatic feature requires a specific version of Django, any version checking/warning should occur as part of that feature.
GUS-W-11593026.