🐥 Good First Issue
This issue is a great fit for first-time contributors looking to get familiar with the Hiero C++ SDK codebase.
Good First Issues are intentionally small and well-scoped. The change is a straightforward rename with no logic to implement — you just need to find the right lines and update the test names to match the established pattern.
👾 Description of the Task
The equality tests added to TokenNftTransferUnitTests in PR #1371 use the prefix OperatorEqualWith, but the established naming convention across the SDK uses OperatorEquals (with a trailing s).
For reference, see these existing files:
ExchangeRateUnitTests.cc uses OperatorEqualsDefaults, OperatorEqualsSimilar, OperatorEqualsDiff
TokenTransferUnitTests.cc uses OperatorEqualsSame, OperatorEqualsDiff
The six test cases added in PR #1371 need to be renamed to match this convention.
Relevant file:
src/sdk/tests/unit/TokenNftTransferUnitTests.cc
💡 Proposed Approach
Rename the six TEST_F macros in TokenNftTransferUnitTests.cc. No logic changes — only the test name strings change.
👩💻 Implementation Steps
✔️ Acceptance Criteria
📋 Step-by-Step Contribution Guide
Read Workflow Guide for step-by-step workflow guidance. Read README.md for setup instructions.
❗ Pull requests cannot be merged without S and s signed commits. See the Signing Guide.
🤔 Additional Information
If you have questions while working on this issue, feel free to ask! Hiero-SDK-C++ Discord
🐥 Good First Issue
This issue is a great fit for first-time contributors looking to get familiar with the Hiero C++ SDK codebase.
Good First Issues are intentionally small and well-scoped. The change is a straightforward rename with no logic to implement — you just need to find the right lines and update the test names to match the established pattern.
👾 Description of the Task
The equality tests added to
TokenNftTransferUnitTestsin PR #1371 use the prefixOperatorEqualWith, but the established naming convention across the SDK usesOperatorEquals(with a trailings).For reference, see these existing files:
ExchangeRateUnitTests.ccusesOperatorEqualsDefaults,OperatorEqualsSimilar,OperatorEqualsDiffTokenTransferUnitTests.ccusesOperatorEqualsSame,OperatorEqualsDiffThe six test cases added in PR #1371 need to be renamed to match this convention.
Relevant file:
💡 Proposed Approach
Rename the six
TEST_Fmacros inTokenNftTransferUnitTests.cc. No logic changes — only the test name strings change.👩💻 Implementation Steps
Open
src/sdk/tests/unit/TokenNftTransferUnitTests.ccApply the following exact renames:
OperatorEqualWithDefaultConstructedInstancesOperatorEqualsDefaultConstructedOperatorEqualWithIdenticalConstructedInstancesOperatorEqualsSameOperatorEqualWithDifferentNftIdOperatorEqualsDiffNftIdOperatorEqualWithDifferentSenderAccountIdOperatorEqualsDiffSenderAccountIdOperatorEqualWithDifferentReceiverAccountIdOperatorEqualsDiffReceiverAccountIdOperatorEqualWithDifferentIsApprovalOperatorEqualsDiffIsApprovalBuild and run the unit tests to confirm all six renamed tests still pass:
Open a pull request with the change
✔️ Acceptance Criteria
TokenNftTransferUnitTests.ccare renamed exactly as shown in the table above📋 Step-by-Step Contribution Guide
/assignto request the issueREADME.md-s -SRead Workflow Guide for step-by-step workflow guidance. Read README.md for setup instructions.
❗ Pull requests cannot be merged without
Sandssigned commits. See the Signing Guide.🤔 Additional Information
ExchangeRateUnitTests.cc,TokenTransferUnitTests.ccIf you have questions while working on this issue, feel free to ask! Hiero-SDK-C++ Discord