feat: add TokenNftTransfer equality operator#1371
feat: add TokenNftTransfer equality operator#1371rwalworth merged 1 commit intohiero-ledger:mainfrom
Conversation
Signed-off-by: cheese-cakee <farzanaman99@gmail.com>
|
Hey @cheese-cakee 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1299 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
rwalworth
left a comment
There was a problem hiding this comment.
LGTM - the implementation is clean and correct, and the test coverage is solid. Left one small nitpick below on test naming, but nothing blocking. Running the workflows now and will merge once they pass!
|
👋 Hi @cheese-cakee! Great work on your recent contribution! 🎉 Here are some issues you might want to explore next:
Happy coding! 🚀 |
|
Sorry I couldn't get back to solve the test naming issue on time! Thanks for merging tho :) |
Description
This PR adds operator== support to TokenNftTransfer and unit coverage for equality behavior, following the existing SDK value-type pattern.
Related Issue
operator==toTokenNftTransfer#1299What Changed
Equality compares exactly these fields:
Test Coverage Added
Notes