-
Notifications
You must be signed in to change notification settings - Fork 283
[suggestion] Refactor Iroha CLI #4136
Copy link
Copy link
Closed
Labels
CLIRefactorImprovement to overall code qualityImprovement to overall code qualityconfig-changesChanges in configuration and start up of the IrohaChanges in configuration and start up of the Irohairoha2-devThe re-implementation of a BFT hyperledger in RUSTThe re-implementation of a BFT hyperledger in RUST
Metadata
Metadata
Assignees
Labels
CLIRefactorImprovement to overall code qualityImprovement to overall code qualityconfig-changesChanges in configuration and start up of the IrohaChanges in configuration and start up of the Irohairoha2-devThe re-implementation of a BFT hyperledger in RUSTThe re-implementation of a BFT hyperledger in RUST
Type
Projects
Status
In review
Description
Apart from not using
clap, the CLI (irohabinary) has other issues:test_networkcrate can re-useIroharoot orchestrator in test enviroha::sampleswith data samples for tests. Doesn't seem to relate to CLI at all.Toriiis defined here; again, it is not really related to CLI and rather deserves to be moved somewhere.To address this issues and make another steps towards the Configuration Overhaul RFC (#2585), I propose the following actions.
Actions
Toriifromiroha; make it a separateiroha_toriicrate. It is a self-contained module, focusing on Iroha HTTP API. While core enough to belong toiroha_core(like Sumeragi or Kura), IMO it would better be a separate crate because its peripheral role, and it's a good candidate to be a standalone compilation unit.iroha_toriifromiroha#4139Irohastartup; set it up on a higher level (e.g. CLI)iroha::samplesfromiroha; maybe, make a separatetest_samplescrate or something.Irohastructure & logic out of CLI, e.g. intoiroha_orchestratoror something.clapversion ofiroha_client_cli)genesis.fileconfiguration parameter as outlined in [suggestion] Simplify genesis config #4029