refactor: revert logger.level, add logger.filter, extend config routes#5384
Merged
0x009922 merged 2 commits intohyperledger-iroha:mainfrom Apr 4, 2025
Merged
Conversation
0x009922
added
api-changes
0x009922
requested review from
DCNick3,
dima74,
mversic,
outoftardis and
s8sato
as code owners
0x009922
changed the title
logger.level, add logger.filter, extend config routes
0x009922
changed the title
logger.level, add logger.filter, extend config routeslogger.level, add logger.filter, extend config routes
0x009922
force-pushed
the
log-filter-cfg-endpoint
branch
from
8b0d594 to
ce13d17
Compare
…outes Close hyperledger-iroha#5365 Close hyperledger-iroha#5247 Revert hyperledger-iroha#4837 Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922
force-pushed
the
log-filter-cfg-endpoint
branch
from
ce13d17 to
defe862
Compare
aoyako
approved these changes
Apr 1, 2025
s8sato
approved these changes
Apr 3, 2025
This was referenced Apr 7, 2025
0x009922
added a commit
to 0x009922/iroha
that referenced
this pull request
Apr 9, 2025
+ some residuals from hyperledger-iroha#5384 Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922
added a commit
to 0x009922/iroha
that referenced
this pull request
Apr 30, 2025
+ some residuals from hyperledger-iroha#5384 Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5365
Close #5247
Partially revert #4837
Config Changes
logger.level(LOG_LEVEL) to its original state. It does no longer accept "directives", but only plain log level.logger.filter(LOG_FILTER) that supports the directives syntax. It is an optional parameter.logger.levelandlogger.filter, they are combined. It means that iflogger.level = "INFO"andlogger.filter = "iroha_core=debug", the resulting filter set will beinfo,iroha_core=debug.TEST_LOG_FILTERenv for test loggerAPI Changes
GET /configreturns more parameters:logger.filternetwork.block_gossip_sizenetwork.block_gossip_period_msnetwork.transaction_gossip_sizenetwork.transaction_gossip_period_msqueue.capacityPOST /configaccepts bothlogger.levelandlogger.filter