feat!: explicit opt-in for config update #5369#5390
Merged
0x009922 merged 1 commit intohyperledger-iroha:mainfrom May 1, 2025
Merged
feat!: explicit opt-in for config update #5369#53900x009922 merged 1 commit intohyperledger-iroha:mainfrom
0x009922 merged 1 commit intohyperledger-iroha:mainfrom
Conversation
0x009922
added
api-changes
0x009922
requested review from
DCNick3,
dima74,
mversic,
outoftardis and
s8sato
as code owners
dima74
previously approved these changes
Apr 18, 2025
s8sato
previously approved these changes
Apr 21, 2025
+ some residuals from hyperledger-iroha#5384 Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922
force-pushed
the
5369-allow-config-update
branch
from
bd99025 to
569c9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5369
Summary:
torii.allow_config_updateconfig param, affectingPOST /configurationendpointALLOW_CONFIG_UPDATE=trueiniroha_swarm-generated Docker Compose configuration, as it is not intended for productionlogger.level, addlogger.filter, extend config routes #5384Config Changes
Added new parameter -
torii.allow_config_update(boolean, defaultfalse)Example in
.toml:Example in Env:
API Changes
POST /configurationnow returns403 Forbiddeniftorii.allow_config_updateis not set totrue.