You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This means we can more reliably detect colour fields (e.g. building:colour=*, roof:colour=*), rather than the current logic in iD which would erroneoulsy match tags like seamark:buoy_cardinal:colour_pattern=*
Ah, one more thing. I overlooked that you chose the British spelling colour while one other field (localized) uses American spelling. I think it would probably be better if we remain consistent in that regard, wouldn't it?
@tyrasd, this PR is approved, but only you are able to merge. Is there anything holding up a merge, such as needing to migrate id-tagging-schema’s roof:colour field back to the colour field type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
Follow-up from openstreetmap/iD#8782 (comment)
This means we can more reliably detect colour fields (e.g.
building:colour=*,roof:colour=*), rather than the current logic in iD which would erroneoulsy match tags likeseamark:buoy_cardinal:colour_pattern=*