add preview for colour input#8782
Merged
tyrasd merged 1 commit intoopenstreetmap:developfrom Dec 1, 2021
Merged
Conversation
k-yle
commented
Nov 1, 2021
k-yle
commented
Nov 1, 2021
1ec5
reviewed
Nov 1, 2021
tyrasd
added
enhancement
Member
|
Thanks @k-yle! FYI: Before merging this PR, I've added a hidden color input field to be able to let the user choose a color using the browser's native colour picker dialog after clicking on the colour preview box. |
This was referenced Jan 24, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a preview box next to colour inputs. This should help prevent typos, and make it easier for people who aren't familiar with hex codes.
also closes #8289 and closes #8894 , see #8782 (comment)