fix(test): --experimental-vm-modulesを追加してJest + AWS SDK ESMエラーを修正#778
Merged
Conversation
全パッケージのtestスクリプトで@aws-sdk v3のdynamic importによる ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAGエラーを解消する。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
node --experimental-vm-modules node_modules/.bin/jest はpnpm環境では .bin/jestがシェルスクリプトのためSyntaxErrorが発生する。 NODE_OPTIONS=--experimental-vm-modulesを使う方式に変更する。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Files selected (8)
- packages/bootstrap/package.json (1)
- packages/command/domain/package.json (1)
- packages/command/interface-adaptor-if/package.json (1)
- packages/command/interface-adaptor-impl/package.json (1)
- packages/command/processor/package.json (1)
- packages/infrastructure/package.json (1)
- packages/query/interface-adaptor/package.json (1)
- packages/rmu/package.json (1)
Files not summarized due to errors (8)
- packages/command/interface-adaptor-if/package.json (nothing obtained from openai)
- packages/command/interface-adaptor-impl/package.json (nothing obtained from openai)
- packages/bootstrap/package.json (nothing obtained from openai)
- packages/command/domain/package.json (nothing obtained from openai)
- packages/infrastructure/package.json (nothing obtained from openai)
- packages/command/processor/package.json (nothing obtained from openai)
- packages/rmu/package.json (nothing obtained from openai)
- packages/query/interface-adaptor/package.json (nothing obtained from openai)
Files not reviewed due to errors (8)
- packages/command/domain/package.json (no response)
- packages/command/processor/package.json (no response)
- packages/command/interface-adaptor-if/package.json (no response)
- packages/command/interface-adaptor-impl/package.json (no response)
- packages/bootstrap/package.json (no response)
- packages/infrastructure/package.json (no response)
- packages/rmu/package.json (no response)
- packages/query/interface-adaptor/package.json (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
mysql:9.6でMYSQL_PWD方式が非推奨となりヘルスチェックが失敗していた。 mysqladmin pingに変更し、start_periodを追加してMySQL起動完了を待つ。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Files selected (1)
- tools/docker-compose/docker-compose-databases.yml (1)
Files not summarized due to errors (1)
- tools/docker-compose/docker-compose-databases.yml (nothing obtained from openai)
Files not reviewed due to errors (1)
- tools/docker-compose/docker-compose-databases.yml (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testスクリプトで@aws-sdkv3 の dynamic import が Jest の vm モジュール経由で呼ばれERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAGエラーが発生していたnode --experimental-vm-modules node_modules/.bin/jest --no-cacheに変更して解消対象パッケージ
packages/bootstrappackages/infrastructurepackages/rmupackages/command/domainpackages/command/interface-adaptor-ifpackages/command/interface-adaptor-implpackages/command/processorpackages/query/interface-adaptorTest plan
🤖 Generated with Claude Code
Note
Low Risk
Changes are limited to test runner configuration and local docker-compose healthchecks, with no production runtime or business logic impact.
Overview
Fixes Jest test execution across packages by updating each package’s
testscript to run withNODE_OPTIONS=--experimental-vm-modules, addressing ESM/dynamic import failures (notably from@aws-sdkv3) under Jest.Also updates
tools/docker-compose/docker-compose-databases.ymlto use amysqladmin pinghealthcheck with explicit timing/retry settings, improving container readiness detection for dependent services.Written by Cursor Bugbot for commit a5f9714. This will update automatically on new commits. Configure here.