fix(build): restore Windows compile and add windows CI job

[jdx]

Summary

The v2.9.0 release pipeline failed on both Windows targets (run 25281536062) due to two recently-merged PRs that didn't cfg-gate Unix-only code:

• feat: keep ANSI by default and impl PTY mode #408 added src/supervisor/pty.rs (uses std::os::fd) and a bare mod pty; in supervisor/mod.rs — std::os::fd doesn't exist on Windows.
• feat: customize stop signal and refactor config types #406 introduced libc::SIG* references in src/config_types.rs, but libc is gated to [target.'cfg(unix)'] in Cargo.toml.

This PR:

• Gates mod pty; behind cfg(unix).
• Replaces libc::SIG* lookups in StopSignal with platform-portable constants — libc on Unix (where signal numbers vary across BSD/Linux), hardcoded POSIX-typical values on Windows. The Windows constants are only used for parsing/Display; procs::kill ignores stop_signal on Windows and uses TerminateProcess via sysinfo.
• Cleans up the incidental Windows-only warnings in the same touched files (unused imports, unused vars, dead-code variant, needless return).
• Adds a windows-build CI job running cargo check --lib --bins --all-features on windows-latest. Integration tests under tests/ use lsof/pkill and are Unix-only, so we limit the check to lib + bins. This catches the regression in PR CI rather than the release pipeline.

A follow-up patch release will be needed since v2.9.0 shipped with no Windows binaries.

Test plan

• cargo check --all-targets --all-features (Linux) clean
• cargo check --target x86_64-pc-windows-gnu --all-features clean
• cargo clippy --all-targets --all-features -- -D warnings (Linux) clean
• cargo clippy --lib --bins --target x86_64-pc-windows-gnu -- -D warnings clean
• New windows-build CI job passes on this PR

🤖 Generated with Claude Code

---

Note

Low Risk
Low risk: changes are primarily platform cfg gating and CI configuration to catch Windows-only compile issues; runtime behavior is unchanged except for stop-signal parsing/display constants on Windows.

Overview
Restores Windows compatibility by cfg-gating Unix-only modules/imports (e.g. supervisor::pty, Unix signal handling) and fixing Windows-only warnings/unused code paths.

Makes StopSignal platform-portable by using libc signal numbers on Unix and POSIX-typical constants on Windows, and adjusts Windows process-kill code to ignore unused stop-signal parameters.

Adds a new GitHub Actions windows-build job that runs cargo check --lib --bins --all-features on windows-latest to catch Windows compile regressions in PR CI.

^{Reviewed by Cursor Bugbot for commit d3c3830. Bugbot is set up for automated code reviews on this repo. Configure here.}

[greptile-apps]

Greptile Summary

This PR restores Windows compilation by #[cfg(unix)]-gating mod pty and replacing unconditional libc::SIG* references with platform-conditional constants, and adds a windows-build CI job to catch such regressions in PR CI instead of the release pipeline. The remaining changes are incidental warning cleanups (unused imports, dead-code variants, unused variables) in the files that were touched.

Confidence Score: 4/5

Safe to merge; all changes are compile-fix and warning-cleanup with no logic changes on Unix paths.

All findings are P2 (style/best-practice). The Windows CI job lacks an explicit toolchain pin, and the cfg_attr-on-let pattern in logs.rs is unconventional, but neither affects correctness. No P0 or P1 issues found.

.github/workflows/ci.yml — consider adding an explicit Rust toolchain step to match rust-version = 1.87 declared in Cargo.toml.

Important Files Changed

Filename	Overview
.github/workflows/ci.yml	Adds windows-build CI job using cargo check --lib --bins --all-features; no explicit Rust toolchain step to match declared rust-version = "1.87"
src/config_types.rs	Replaces unconditional libc::SIG* references with #[cfg(unix)] imports and #[cfg(windows)] hardcoded POSIX constants; logic is sound since Windows uses TerminateProcess and ignores stop_signal at runtime
src/supervisor/mod.rs	Gates mod pty and use std::collections::HashSet behind #[cfg(unix)]; tokio::signal correctly left un-gated since the Windows signals() impl uses signal::ctrl_c()
src/supervisor/pty.rs	Removes redundant per-function #[cfg(unix)] on openpty(); the whole module is already gated in mod.rs, so this is correct cleanup with no functional change
src/procs.rs	Gates use crate::settings::settings to Unix; uses let _ = (stop_signal, stop_timeout) to suppress unused-variable warnings in the Windows branch; removes unreachable return
src/proxy/server.rs	Moves use std::io::Write inside #[cfg(unix)] blocks at two call sites, eliminating unused-import warnings on Windows; correct and low-risk
src/web/routes/logs.rs	Suppresses dead-code and unused-variable warnings for non-Unix targets via #[allow(dead_code)] and #[cfg_attr]; works but _-prefix idiom would be simpler
src/main.rs	Gates use tokio::signal to #[cfg(unix)]; correct since the only usage in this file is signal::unix::signal() which is Unix-only
src/deps.rs	Removes unused Retry import from test module
src/state_file.rs	Removes unused Retry import from test module

_{Reviews (1): Last reviewed commit: "fix(build): restore Windows compile and ..." | Re-trigger Greptile}

[greptile-apps]

Missing Rust toolchain setup step

The windows-build job relies on the Rust version that happens to be pre-installed on the windows-latest runner. Cargo.toml declares rust-version = "1.87", but GitHub's hosted runners ship whatever Rust stable was current when the image was built — that may lag behind. Adding an explicit dtolnay/rust-toolchain action (or similar) ensures the Windows job uses the same pinned version managed by mise on the Linux job and prevents silent version drift.

[greptile-apps]

Prefer _-prefix over cfg_attr for unused-variable suppression

#[cfg_attr(not(unix), allow(unused_variables))] on a let statement is uncommon and easy to misread. Since both poll_count and opened_fresh are only consumed inside #[cfg(unix)] blocks, the simpler and more idiomatic way to silence the warning on non-Unix targets is to use a leading underscore in the binding itself (let _poll_count = poll_count;), which requires no attribute at all.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!