-
-
Notifications
You must be signed in to change notification settings - Fork 27
fix(build): restore Windows compile and add windows CI job #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -389,6 +389,7 @@ pub async fn stream_sse( | |
| let mut file_handle: Option<std::fs::File> = None; | ||
|
|
||
| // Internal result type for file operations within spawn_blocking | ||
| #[allow(dead_code)] // FileRotated is constructed only on Unix | ||
| enum FileOpResult { | ||
| Data(Vec<u8>), | ||
| Truncated, | ||
|
|
@@ -417,8 +418,10 @@ pub async fn stream_sse( | |
| let fh = file_handle.take(); | ||
| let mut ls = last_size; | ||
| let prev_ino = last_path_ino; | ||
| #[cfg_attr(not(unix), allow(unused_variables))] | ||
| let poll_count = poll_count; | ||
| tokio::task::spawn_blocking(move || { | ||
| #[cfg_attr(not(unix), allow(unused_variables))] | ||
| let opened_fresh = fh.is_none(); | ||
|
Comment on lines
+421
to
425
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| let mut file = match fh { | ||
| Some(f) => f, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
windows-buildjob relies on the Rust version that happens to be pre-installed on thewindows-latestrunner.Cargo.tomldeclaresrust-version = "1.87", but GitHub's hosted runners ship whatever Rust stable was current when the image was built — that may lag behind. Adding an explicitdtolnay/rust-toolchainaction (or similar) ensures the Windows job uses the same pinned version managed bymiseon the Linux job and prevents silent version drift.