feat: support files other than js to be ESM#10823
Conversation
ec07558 to
d4fe7ec
Compare
|
If we're running in ESM mode, shouldn't we treat all |
|
How would ESM mode be "triggered"? Also, it's perfectly fine to use |
1dec5a1 to
0a103ee
Compare
|
I'm thinking we can land this so people can test this, and if we figure out a better approach in the future we can revert |
|
I think custom transformer guidance also needs updating ? |
c4095c6 to
0d41121
Compare
Done in #10834 - this PR doesn't change that fact (i.e. use |
0d41121 to
e8f3cc4
Compare
44e87b6 to
d4600f5
Compare
1892952 to
7ffb156
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #9860. See that issue for some discussion.
We could have an option somewhere for transformers to decide, but then we'd have have some forking logic in
jest-runtime. Just having a top level option seems easier to reason about to me. Open to being convinced otherwise, tho! 👍Test plan
E2E test added, plus unit tests for the config verification.