Remove testMatch from package.json#4630
Conversation
|
Ok, the snapshot one was just a @mjesun Ideas about the The Failing tests: |
|
On CI the worker test doesn't fail... @pedrottimark mentioned it only fails if run without It points to another test failing which I just didn't wait for, though, the one added in #3672 earlier today. @EnoahNetzach Could you take a look? |
|
I won't have time before this weekend. |
|
Rebased on master, but a new failure has snuck in, so we're still at 2 failures! The new test from #3458. /cc @felipeochoa The sourcemap test passes on node 8, but not 4 or 6 |
|
Open PR for the sourcemap test: #4744. |
|
Rebased, and now we're down to the single |
|
Rebased, and skipping the failing test. Hopefully green ci... |
Codecov Report
@@ Coverage Diff @@
## master #4630 +/- ##
==========================================
+ Coverage 60.35% 60.74% +0.39%
==========================================
Files 198 197 -1
Lines 6639 6596 -43
Branches 4 4
==========================================
Hits 4007 4007
+ Misses 2632 2589 -43
Continue to review full report at Codecov.
|
|
This is so good, thanks for doing this. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |


Summary
I discovered that the
testMatchin the root package.json meant that a few test suites did not run.One was simply old, so I deleted it. Then a bunch of extra files in
__tests__tried to run, so I ignored them.But it still leaves 3 tests which fails.
Test plan
Green CI (eventually)