Allow unmatched test paths from CLI#3882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
- Coverage 60.58% 60.56% -0.03%
==========================================
Files 201 201
Lines 6686 6690 +4
Branches 4 4
==========================================
+ Hits 4051 4052 +1
- Misses 2635 2638 +3
Continue to review full report at Codecov.
|
boujeepossum
left a comment
boujeepossum
left a comment
There was a problem hiding this comment.
aren't those two separate issues?
i'd split it into two PRs
the console part looks awesome :)
| path, | ||
| })); | ||
|
|
||
| const fileExists = (filePath: string) => { |
There was a problem hiding this comment.
we already have like 3 functions like this in the codebase. It sucks that we can't just share it :(
There was a problem hiding this comment.
I would share it between packages too, but where to put it? Into jest-util?
| let timeout = null; | ||
|
|
||
| const doFlush = () => { | ||
| const flushBufferedIO = () => { |
There was a problem hiding this comment.
it's not really an IO, more like.. just O :)
There was a problem hiding this comment.
maybe just call it flushBufferedOutput?
|
|
||
| flushDebouncedIO() { | ||
| for (const io of this._bufferedIO) { | ||
| io(); |
There was a problem hiding this comment.
this should be flushBufferedOutput() as well
valerybugakov
force-pushed
the
cli-test-filenames
branch
from
463c7e8 to
8137ae2
Compare
thymikee
changed the title
|
Removed part about |
|
cc @aaronabramov what's the status of this? Is this good for 21? |
|
I'd like to see a flag added for the old behaviour. Or at least output a string saying that during a normal test run the file would not be executed. It's useful info when trying to understand why a test is not run in CI (ref #4630) |
| /** | ||
| * Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
| * | ||
| * This source code is licensed under the BSD-style license found in the |
|
@valerybugakov do you mind addressing the change requests by @SimenB? |
valerybugakov
force-pushed
the
cli-test-filenames
branch
from
2b8db4a to
2a360b2
Compare
|
@cpojer np, rebased with master |
|
@valerybugakov do you mind also fixing the tests so we can land this? :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
7 participants
Summary
Fixes #3755 and #3793
Test plan
Examples provided in issues above.
Added an ability to run tests by provided filenames:
jest ../foo.js ../tests/bar.js ./src/baz.jsWill add tests if fixes are ok.