Add note for matching files via CLI#5544
Closed
rickhanlonii wants to merge 1 commit intojestjs:masterfrom
Closed
Conversation
thymikee
approved these changes
Feb 13, 2018
Contributor
|
Does this need a changelog entry? @SimenB |
Member
|
I'm starting to like #3882 less and less :( Should need a changelog |
Member
|
I agree with @SimenB. I think we should consider reverting that PR partially. I totally messed up there. Jest should never run tests that are excluded through the config. Is there somebody who'd like to send the revert? |
Member
Author
|
Yeah I'll send it |
This was referenced Mar 7, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting in this change we've started to ignore matchers for files passed in via the CLI
This PR adds a note that files passed this way will be tested even though they may normally not be included
Closes #5527
Test plan
Screen