Skip to content

Lint markdown in CI#5645

Merged
cpojer merged 1 commit intojestjs:masterfrom
rickhanlonii:chore/rh-lint-md-ci
Feb 23, 2018
Merged

Lint markdown in CI#5645
cpojer merged 1 commit intojestjs:masterfrom
rickhanlonii:chore/rh-lint-md-ci

Conversation

@rickhanlonii
Copy link
Copy Markdown
Member

Summary

This PR adds a check to CI for failed markdown linting

Test plan

N/A

Comment thread package.json
"lint": "eslint . --cache --ext js,md",
"lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5",
"lint:md": "prettier docs/**/*.md packages/*/README.md packages/*/docs/**/*.md website/blog/*.md .github/*.md CHANGELOG.md CONTRIBUTING.md website/README.md README.md --write",
"lint:md": "prettier '**/*.md' --write",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that these two commands are equivalent, not sure what we were filtering before

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were supposed to not edit README.md, seems like that changed

Copy link
Copy Markdown
Member Author

@rickhanlonii rickhanlonii Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 README.md is the last file listed in the original command

Copy link
Copy Markdown
Member

@SimenB SimenB Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #5378, see #4853 (comment) for why it was excluded

@cpojer cpojer merged commit c91ee66 into jestjs:master Feb 23, 2018
@cpojer
Copy link
Copy Markdown
Member

cpojer commented Feb 23, 2018

Got a timeout on CI, we should probably adjust the failing test.

@rickhanlonii rickhanlonii deleted the chore/rh-lint-md-ci branch February 23, 2018 15:30
Comment thread package.json
"lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5",
"lint:md": "prettier docs/**/*.md packages/*/README.md packages/*/docs/**/*.md website/blog/*.md .github/*.md CHANGELOG.md CONTRIBUTING.md website/README.md README.md --write",
"lint:md": "prettier '**/*.md' --write",
"lint:md:ci": "prettier '**/*.md' --list-different",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use prettylint?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BYK pushed a commit that referenced this pull request Feb 23, 2018
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants