Skip to content

Lint markdown in CI #5645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 1 commit into from
Feb 23, 2018
Merged

Lint markdown in CI #5645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/ManualMocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ other than the project root) and will be **automatically** mocked. There's no
need to explicitly call `jest.mock('module_name')`.

Scoped modules can be mocked by creating a file in a directory structure that
matches the name of the scoped module. For example, to mock a scoped module
matches the name of the scoped module. For example, to mock a scoped module
called `@scope/project-name`, create a file at
`__mocks__/@scope/project-name.js`, creating the `@scope/` directory
accordingly.
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,12 @@
"jest-coverage": "yarn jest --coverage",
"lint": "eslint . --cache --ext js,md",
"lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5",
"lint:md": "prettier docs/**/*.md packages/*/README.md packages/*/docs/**/*.md website/blog/*.md .github/*.md CHANGELOG.md CONTRIBUTING.md website/README.md README.md --write",
"lint:md": "prettier '**/*.md' --write",
Copy link
Copy Markdown
Member Author

@rickhanlonii rickhanlonii Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that these two commands are equivalent, not sure what we were filtering before

Copy link
Copy Markdown
Member

@SimenB SimenB Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were supposed to not edit README.md, seems like that changed

Copy link
Copy Markdown
Member Author

@rickhanlonii rickhanlonii Feb 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 README.md is the last file listed in the original command

Copy link
Copy Markdown
Member

@SimenB SimenB Feb 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #5378, see #4853 (comment) for why it was excluded

"lint:md:ci": "prettier '**/*.md' --list-different",
Copy link
Copy Markdown
Member

@SimenB SimenB Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use prettylint?

Copy link
Copy Markdown
Member

@SimenB SimenB Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5651

"postinstall": "yarn build",
"publish": "yarn build-clean && yarn build && lerna publish --silent",
"test-ci-es5-build-in-browser": "karma start --single-run",
"test-ci": "yarn typecheck && yarn lint && yarn lint-es5-build && yarn jest-coverage -- -i && node scripts/mapCoverage.js && codecov",
"test-ci": "yarn typecheck && yarn lint && yarn lint-es5-build && yarn lint:md:ci && yarn jest-coverage -i && node scripts/mapCoverage.js && codecov",
"test-ci-partial": "yarn jest -i",
"test-pretty-format-perf": "node packages/pretty-format/perf/test.js",
"test": "yarn typecheck && yarn lint && yarn jest",
Expand Down
⚡