This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Complete placeholder font & icon active color#119
Closed
AgapovOne wants to merge 11 commits intojobandtalent:masterfrom
Closed
Complete placeholder font & icon active color#119AgapovOne wants to merge 11 commits intojobandtalent:masterfrom
AgapovOne wants to merge 11 commits intojobandtalent:masterfrom
Conversation
Add placeholderFont property
…1-PlaceholderFont Add placeholderFont handling
Placeholder fixes
Draw password toggleable icon with active color
victorBaro
approved these changes
Mar 19, 2019
Contributor
victorBaro
left a comment
victorBaro
left a comment
There was a problem hiding this comment.
Please remove setter before merging.
Nice PR, thank you.
|
|
||
| public var rightView: UIView? { | ||
| get { return nil } | ||
| set { } |
Contributor
Author
There was a problem hiding this comment.
UITextField public interface requires setter.
Yes, this code is unused in text view, but it's needed for AnimatedTextField
| let lineHeight: CGFloat = 3 | ||
| let errorColor = UIColor.red | ||
| let textInputFont = UIFont.systemFont(ofSize: 14) | ||
| let placeHolderFont = UIFont.systemFont(ofSize: 14) |
Contributor
There was a problem hiding this comment.
Just curious.. Have you tried that the component is working when placeHolderFont.pointSize > textInputFont.pointSize ?
Contributor
Author
There was a problem hiding this comment.
It will work, but basically you want input font & placeholder font to be the same.
... Now I start thinking if we ever need to set placeholderFont to anything other than textInputFont.
…Input into jobandtalent-master # Conflicts: # AnimatedTextInput/Classes/AnimatedTextInput.swift # AnimatedTextInput/Classes/AnimatedTextView.swift
Contributor
Author
|
@victorBaro Nothing else to change, please acccept |
iceman201
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #91, #103, #110
Updated readme style, style in example project.
Checked on iOS 12 XS.
Ran tests (did not find snapshot references)