This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add placeHolderFont to AnimatedTextInputStyle#91
Open
Zyoma108 wants to merge 2 commits intojobandtalent:masterfrom
Zyoma108:master
Open
Add placeHolderFont to AnimatedTextInputStyle#91Zyoma108 wants to merge 2 commits intojobandtalent:masterfrom Zyoma108:master
Zyoma108 wants to merge 2 commits intojobandtalent:masterfrom
Zyoma108:master
Conversation
victorBaro
suggested changes
Jan 4, 2018
Contributor
victorBaro
left a comment
victorBaro
left a comment
There was a problem hiding this comment.
Thank you for submitting your PR. I like it, it can be very helpful.
Take a look at my comments and hopefully it can be merged soon :)
| let fontSize = style.textInputFont.pointSize | ||
| let fontSize = style.placeHolderFont.pointSize | ||
| placeholderLayer.fontSize = fontSize | ||
| placeholderLayer.font = style.textInputFont |
Contributor
There was a problem hiding this comment.
Please review your code, you missed this one:
placeholderLayer.font = style.placeHolderFont
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.