Skip to content

Prefer const over let#3

Merged
crobinson42 merged 2 commits intojs-data:masterfrom
LinusU:prefer-const
Nov 21, 2018
Merged

Prefer const over let#3
crobinson42 merged 2 commits intojs-data:masterfrom
LinusU:prefer-const

Conversation

@LinusU
Copy link
Copy Markdown
Contributor

@LinusU LinusU commented Oct 10, 2018

In order to comply with this new standard rule ☺️

standard/eslint-config-standard#133

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Nov 21, 2018

ping @jmdobry, @techniq ☺️

@crobinson42
Copy link
Copy Markdown
Member

Thanks for the PR, out of curiosity, what triggered this need for a change?

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Nov 21, 2018

We want to enable the rule prefer-const in the next version of Standard, and there were a few packages that were currently breaking that rule. After this and five other PRs are merged every standard package should be compliant and we can add the rule ☺️

You can read some background discussion here: standard/standard#159 and see the pr here: standard/eslint-config-standard#133

@crobinson42 crobinson42 merged commit 89eb9f5 into js-data:master Nov 21, 2018
@LinusU LinusU deleted the prefer-const branch November 21, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants