Skip to content

Prefer const over let #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crobinson42 merged 2 commits into from
Nov 21, 2018
Merged

Prefer const over let #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
902e908
Prefer const over let
LinusU Oct 10, 2018
9a52c04
Follow standard style in webpack config
LinusU Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/findAll.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = function (options) {
})

it('should filter users', async function () {
let props = { name: 'John' }
const props = { name: 'John' }
assert.debug('findAll', { age: 30 })
const users = await adapter.findAll(User, { age: 30 })
assert.debug('found', JSON.stringify(users, null, 2))
Expand Down Expand Up @@ -120,7 +120,7 @@ module.exports = function (options) {

props = { content: 'test2', postId: post[Post.idAttribute], userId: post.userId }
assert.debug('create', props)
let comment = await adapter.create(Comment, props)
const comment = await adapter.create(Comment, props)
assert.debug('created', JSON.stringify(comment, null, 2))

props = { name: 'Sally' }
Expand All @@ -135,7 +135,7 @@ module.exports = function (options) {

props = { content: 'test67', postId: post2[Post.idAttribute], userId: post2.userId }
assert.debug('create', props)
let comment2 = await adapter.create(Comment, props)
const comment2 = await adapter.create(Comment, props)
assert.debug('created', JSON.stringify(comment2, null, 2))

assert.debug('findAll')
Expand Down Expand Up @@ -168,7 +168,7 @@ module.exports = function (options) {

props = { content: 'test2', postId: post[Post.idAttribute], userId: post.userId }
assert.debug('create', props)
let comment = await adapter.create(Comment, props)
const comment = await adapter.create(Comment, props)
assert.debug('created', JSON.stringify(comment, null, 2))

props = { name: 'Sally' }
Expand All @@ -183,7 +183,7 @@ module.exports = function (options) {

props = { content: 'test67', postId: post2[Post.idAttribute], userId: post2.userId }
assert.debug('create', props)
let comment2 = await adapter.create(Comment, props)
const comment2 = await adapter.create(Comment, props)
assert.debug('created', JSON.stringify(comment2, null, 2))

assert.debug('find')
Expand Down
2 changes: 1 addition & 1 deletion webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ module.exports = {
}
]
}
};
}
⚡