Skip to content

replace name with address in format argument#282

Closed
mstine wants to merge 1 commit into
kelseyhightower:masterfrom
mstine:fix-public-ip-command
Closed

replace name with address in format argument#282
mstine wants to merge 1 commit into
kelseyhightower:masterfrom
mstine:fix-public-ip-command

Conversation

@mstine

@mstine mstine commented Jan 2, 2018

Copy link
Copy Markdown

Minor bug fix in this doc.

@martinmosegaard

Copy link
Copy Markdown
Contributor

Can you explain this change? I have just gone through the tutorial and don't remember that stuff broke at this point.

One related thing did bite me though: First we use the variable KUBERNETES_PUBLIC_ADDRESS to hold the name, for the external network load balancer resources. Then, in verification, we reuse the variable to hold the address. At first, I did not update the variable (so it still held the name), and then the curl command failed.

Thanks.

@awly

awly commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

It seems to work both ways (with reserved address name and IP).
Feel free to reject #294 if you decide that using actual IP is the right way.

@kelseyhightower

Copy link
Copy Markdown
Owner

Let's leave it alone for now because it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants