Skip to content

Fix env variable KUBERNETES_PUBLIC_ADDRESS#312

Closed
alban wants to merge 1 commit into
kelseyhightower:masterfrom
kinvolk-archives:alban/fix-address
Closed

Fix env variable KUBERNETES_PUBLIC_ADDRESS#312
alban wants to merge 1 commit into
kelseyhightower:masterfrom
kinvolk-archives:alban/fix-address

Conversation

@alban

@alban alban commented Feb 6, 2018

Copy link
Copy Markdown

Symptoms:

$ echo $KUBERNETES_PUBLIC_ADDRESS
kubernetes-the-hard-way

With this patch, I get the IP address instead of the name.

Symptoms:
$ echo $KUBERNETES_PUBLIC_ADDRESS
kubernetes-the-hard-way

With this patch, I get the IP address instead of the name.
@alban

alban commented Feb 6, 2018

Copy link
Copy Markdown
Author

Oops I missed the discussion in #299 and #282 that says it works both ways anyway.

Since $KUBERNETES_PUBLIC_ADDRESS is the IP in other part of the doc, including in the same file, I think it's better to use the IP though.

@kelseyhightower

Copy link
Copy Markdown
Owner

I'll now use address everywhere to avoid confusion. This is fixed on the 1.10.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants