Fix using the addon as a runtime dependency of another addon#43
Merged
jneurock merged 1 commit intokloeckner-i:masterfrom Apr 13, 2020
bertdeblock:fix-using-addon-as-runtime-dependency
Merged
Fix using the addon as a runtime dependency of another addon#43jneurock merged 1 commit intokloeckner-i:masterfrom bertdeblock:fix-using-addon-as-runtime-dependency
jneurock merged 1 commit intokloeckner-i:masterfrom
bertdeblock:fix-using-addon-as-runtime-dependency
Conversation
bertdeblock
commented
Apr 13, 2020
| }, | ||
| included(app) { | ||
| let config = this.app.project.config(app.env); | ||
| let config = app.project.config(); |
Contributor
Author
There was a problem hiding this comment.
Using app instead of this.app is the actual fix for the error described in the PR description.
bertdeblock
commented
Apr 13, 2020
| let config = app.project.config(); | ||
|
|
||
| this.appEnv = app.env; | ||
| this.appEnv = config.environment; |
Contributor
Author
There was a problem hiding this comment.
When included as a sub-dependency, app.env seems to be undefined which makes the addon exclude itself from the build because of this check. Using config.environment seems to fix this. Not sure if this is the "correct" fix though.
Contributor
|
Thanks for the PR! Since it's late, I'll release this tomorrow morning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When including this addon as a runtime dependency of another addon, I encountered the following error:
Cannot read property 'project' of undefined.The error occurs at this line: https://github.com/kloeckner-i/ember-cli-mirage-graphql/blob/master/index.js#L25
I have set up a reproduction here: https://github.com/bertdeblock/ember-cli-mirage-graphql-repro
The error should occur if you run
ember s(so running the dummy app).This PR should fix this error. 🤞
Let me know if you want me to change anything.