Skip to content

Fix using the addon as a runtime dependency of another addon #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jneurock merged 1 commit into from
Apr 13, 2020
Merged

Fix using the addon as a runtime dependency of another addon #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ module.exports = {
}
},
included(app) {
let config = this.app.project.config(app.env);
let config = app.project.config();
Copy link
Copy Markdown
Contributor Author

@bertdeblock bertdeblock Apr 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using app instead of this.app is the actual fix for the error described in the PR description.


this.appEnv = app.env;
this.appEnv = config.environment;
Copy link
Copy Markdown
Contributor Author

@bertdeblock bertdeblock Apr 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When included as a sub-dependency, app.env seems to be undefined which makes the addon exclude itself from the build because of this check. Using config.environment seems to fix this. Not sure if this is the "correct" fix though.

this.mirageConfig = config['ember-cli-mirage'] || {};

this._super.included.apply(this, arguments);
Expand Down
⚡