Skip to content

fix(plugin): gate iOS debug logs and align plugin metadata#22

Merged
konodioda727 merged 9 commits intokonodioda727:mainfrom
BlackishGreen33:bg/upstream-fix-plugin-gate-ios-debug-and-align-version
Apr 16, 2026
Merged

fix(plugin): gate iOS debug logs and align plugin metadata#22
konodioda727 merged 9 commits intokonodioda727:mainfrom
BlackishGreen33:bg/upstream-fix-plugin-gate-ios-debug-and-align-version

Conversation

@BlackishGreen33
Copy link
Copy Markdown
Contributor

Summary

  • depends on fix(android): harden gradle injection edge cases #21 and is intended to merge after it
  • gate generated JPush iOS debug logging behind #if DEBUG
  • remove legacy global config helpers in favor of explicit mod inputs
  • align createRunOncePlugin metadata with the published package version

Review Notes

Testing

  • npm run build
  • npm test -- --runInBand
  • npm run lint

Copilot AI review requested due to automatic review settings April 16, 2026 02:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Expo config plugin to (1) avoid leaking noisy iOS debug logs into Release builds, (2) remove legacy global config helpers in favor of explicit mod inputs, and (3) align plugin “run once” metadata with the published package version.

Changes:

  • Gate generated iOS JPush debug logging and setDebugMode() behind #if DEBUG.
  • Refactor Android/iOS transforms to stop relying on global config helpers; pass config explicitly and remove legacy helper modules.
  • Update plugin metadata/version strings and extend regression tests for Android Gradle injection edge cases.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugin/src/utils/vendorChannels.ts Removes legacy global vendor channel helpers (now handled via explicit inputs).
plugin/src/utils/config.ts Removes legacy global config storage helpers (globalThis.__JPUSH_CONFIG__).
plugin/src/ios/appDelegate.ts Wraps debug logging / JPUSHService.setDebugMode() with #if DEBUG.
plugin/src/index.ts Aligns createRunOncePlugin version metadata to 1.2.4.
plugin/src/android/projectBuildGradle.ts Inlines vendor-channel helpers and tightens types for vendorChannels.
plugin/src/android/gradleProperties.ts Refactors to accept vendorChannels explicitly and centralizes logic in applyAndroidGradleProperties.
plugin/src/android/appBuildGradle.ts Hardens Gradle injection (no versionName anchor dependency), merges placeholders via +=, and removes legacy generated sections.
plugin/tests/nativeIosAppDelegate.test.ts Adds assertions for #if DEBUG guarding.
plugin/tests/nativeAndroidMods.test.ts Adds regression tests for manifestPlaceholders merge + missing/non-literal versionName.
plugin/tests/iosTransforms.test.ts Removes reliance on legacy setConfig; adds #if DEBUG assertions.
plugin/tests/androidTransforms.test.ts Updates transform tests to pass explicit inputs and reflect new placeholder injection behavior.
app.plugin.js Updates header comment version to 1.2.4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugin/src/android/appBuildGradle.ts
@BlackishGreen33 BlackishGreen33 force-pushed the bg/upstream-fix-plugin-gate-ios-debug-and-align-version branch from d1f6795 to afa3629 Compare April 16, 2026 02:55
@konodioda727 konodioda727 merged commit 9943819 into konodioda727:main Apr 16, 2026
1 check passed
@BlackishGreen33 BlackishGreen33 deleted the bg/upstream-fix-plugin-gate-ios-debug-and-align-version branch April 16, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants