chore(release): prepare 1.2.5#23
Merged
konodioda727 merged 11 commits intokonodioda727:mainfrom Apr 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the mx-jpush-expo repository for the 1.2.5 release by aligning version metadata, updating release/prebuild documentation, and refining native mod generation (especially Android Gradle injection and iOS debug logging behavior).
Changes:
- Bump version metadata to
1.2.5(package + plugin) and addv1.2.5changelog entry. - Refactor native mods: gate iOS debug logs behind
#if DEBUG, and harden Androidapp/build.gradleinjection (append placeholders, avoidversionNameanchors). - Remove legacy global config helpers and update/extend fixture-based regression tests and docs accordingly.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugin/src/utils/vendorChannels.ts | Removed legacy vendor-channel global helper module. |
| plugin/src/utils/config.ts | Removed legacy global config helper module. |
| plugin/src/ios/appDelegate.ts | Wrap JPush debug mode + debug prints with #if DEBUG. |
| plugin/src/index.ts | Align plugin header + createRunOncePlugin version to 1.2.5. |
| plugin/src/android/projectBuildGradle.ts | Inline legacy tag handling/helpers; tighten vendorChannels typing. |
| plugin/src/android/gradleProperties.ts | Make Gradle properties injection depend on passed vendorChannels (no globals). |
| plugin/src/android/appBuildGradle.ts | Rework Gradle injection to be more robust/idempotent; append placeholders and avoid versionName anchors. |
| plugin/tests/nativeIosAppDelegate.test.ts | Assert presence of #if DEBUG around debug behavior. |
| plugin/tests/nativeAndroidMods.test.ts | Add fixture regression tests for host placeholders + versionName edge cases. |
| plugin/tests/iosTransforms.test.ts | Remove dependency on deleted global config helper; assert DEBUG guards. |
| plugin/tests/androidTransforms.test.ts | Update transform tests for new signatures/injection behavior; improve assertions. |
| package.json | Bump package version to 1.2.5. |
| app.plugin.js | Update header version comment to 1.2.5. |
| README.md | Document new prebuild/release behavior and placeholder append strategy. |
| DEVELOPMENT.md | Update testing/release workflow guidance (release PR + npm pack checks + tagging). |
| CHANGELOG.md | Add v1.2.5 entry describing the changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ed144bb to
171f65c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review Notes
Testing