Skip to content

chore(release): prepare 1.2.5#23

Merged
konodioda727 merged 11 commits intokonodioda727:mainfrom
BlackishGreen33:bg/upstream-chore-release-prepare-1-2-5
Apr 16, 2026
Merged

chore(release): prepare 1.2.5#23
konodioda727 merged 11 commits intokonodioda727:mainfrom
BlackishGreen33:bg/upstream-chore-release-prepare-1-2-5

Conversation

@BlackishGreen33
Copy link
Copy Markdown
Contributor

Summary

Review Notes

Testing

  • npm run build
  • npm test -- --runInBand
  • npm run lint

Copilot AI review requested due to automatic review settings April 16, 2026 02:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the mx-jpush-expo repository for the 1.2.5 release by aligning version metadata, updating release/prebuild documentation, and refining native mod generation (especially Android Gradle injection and iOS debug logging behavior).

Changes:

  • Bump version metadata to 1.2.5 (package + plugin) and add v1.2.5 changelog entry.
  • Refactor native mods: gate iOS debug logs behind #if DEBUG, and harden Android app/build.gradle injection (append placeholders, avoid versionName anchors).
  • Remove legacy global config helpers and update/extend fixture-based regression tests and docs accordingly.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
plugin/src/utils/vendorChannels.ts Removed legacy vendor-channel global helper module.
plugin/src/utils/config.ts Removed legacy global config helper module.
plugin/src/ios/appDelegate.ts Wrap JPush debug mode + debug prints with #if DEBUG.
plugin/src/index.ts Align plugin header + createRunOncePlugin version to 1.2.5.
plugin/src/android/projectBuildGradle.ts Inline legacy tag handling/helpers; tighten vendorChannels typing.
plugin/src/android/gradleProperties.ts Make Gradle properties injection depend on passed vendorChannels (no globals).
plugin/src/android/appBuildGradle.ts Rework Gradle injection to be more robust/idempotent; append placeholders and avoid versionName anchors.
plugin/tests/nativeIosAppDelegate.test.ts Assert presence of #if DEBUG around debug behavior.
plugin/tests/nativeAndroidMods.test.ts Add fixture regression tests for host placeholders + versionName edge cases.
plugin/tests/iosTransforms.test.ts Remove dependency on deleted global config helper; assert DEBUG guards.
plugin/tests/androidTransforms.test.ts Update transform tests for new signatures/injection behavior; improve assertions.
package.json Bump package version to 1.2.5.
app.plugin.js Update header version comment to 1.2.5.
README.md Document new prebuild/release behavior and placeholder append strategy.
DEVELOPMENT.md Update testing/release workflow guidance (release PR + npm pack checks + tagging).
CHANGELOG.md Add v1.2.5 entry describing the changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugin/src/android/appBuildGradle.ts Outdated
Comment thread README.md Outdated
@BlackishGreen33 BlackishGreen33 force-pushed the bg/upstream-chore-release-prepare-1-2-5 branch from ed144bb to 171f65c Compare April 16, 2026 02:55
@konodioda727 konodioda727 merged commit b5e5694 into konodioda727:main Apr 16, 2026
1 check passed
@BlackishGreen33 BlackishGreen33 deleted the bg/upstream-chore-release-prepare-1-2-5 branch April 16, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants