[Merged by Bors] - chore: CI detects ProofWidgets toolchain mismatch#31723
[Merged by Bors] - chore: CI detects ProofWidgets toolchain mismatch#31723kim-em wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PR summary 015b41b4dcImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
Naïve question: Is proofwidgets the only dependency where this sort of thing needs to be checked? Could this happen with another new dependency that we add in the future? |
So far it is only ProofWidgets, which does some shenanigans that I don't fully understand to retrieve precompiled artifacts so we don't need It's possible that Canonical will have similar difficulties if we ever manage to add that to Mathlib. |
|
I just checked a recent commit of mathlib4 |
Yes, it would be a pain if the really minor libraries that don't depend on much Lean API needed to be bumped every release as well. |
|
Thanks! |
See zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/ProofWidgets.20not.20building.2C.20says.20it.20is.20out.20of.20date/near/556720459 Ideally, this would fail right now, demonstrating that it is working, but of course CI only runs from the `master` version. Update: now that #31720 is in, this can be merged.
|
Pull request successfully merged into master. Build succeeded: |
See zulip: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/ProofWidgets.20not.20building.2C.20says.20it.20is.20out.20of.20date/near/556720459
Ideally, this would fail right now, demonstrating that it is working, but of course CI only runs from the
masterversion.Update: now that #31720 is in, this can be merged.